Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for reporting files that have not been uploaded #394

Merged
merged 32 commits into from
Jan 3, 2025
Merged

Changes for reporting files that have not been uploaded #394

merged 32 commits into from
Jan 3, 2025

Conversation

nithinb
Copy link
Contributor

@nithinb nithinb commented Nov 21, 2024

No description provided.

@nithinb nithinb self-assigned this Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.23810% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (78cccf5) to head (827452b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../extractorutils/uploader/upload_failure_handler.py 92.85% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   74.50%   74.97%   +0.47%     
==========================================
  Files          40       41       +1     
  Lines        3350     3409      +59     
==========================================
+ Hits         2496     2556      +60     
+ Misses        854      853       -1
Files with missing lines Coverage Δ
cognite/extractorutils/uploader/files.py 88.13% <100.00%> (+2.16%) ⬆️
.../extractorutils/uploader/upload_failure_handler.py 92.85% <92.85%> (ø)

@nithinb nithinb marked this pull request as ready for review December 3, 2024 09:14
@nithinb nithinb requested a review from a team as a code owner December 3, 2024 09:14
@nithinb
Copy link
Contributor Author

nithinb commented Dec 3, 2024

@einarmo I have addressed the changes on this, whenever you get a chance can you review it?

@nithinb nithinb force-pushed the DOG-4448-file-extractor-simplify-extraction-failure-analysis branch from 705dae6 to 865d97a Compare December 6, 2024 06:22
rsjr
rsjr reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@rsjr rsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good, left some comments.

I know it might be a bit tricky, but it would be nice to have some tests describing the behavior and how the file must looks like end the end.

pyproject.toml Outdated Show resolved Hide resolved
cognite/extractorutils/uploader/upload_failure_handler.py Show resolved Hide resolved
@nithinb nithinb force-pushed the DOG-4448-file-extractor-simplify-extraction-failure-analysis branch from 8e18c9b to ee53fb2 Compare December 10, 2024 10:41
@nithinb nithinb force-pushed the DOG-4448-file-extractor-simplify-extraction-failure-analysis branch from 0eb0883 to 5974f9f Compare December 11, 2024 07:01
rsjr
rsjr approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@rsjr rsjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge this after the xmas break

Merge branch 'master' of https://github.com/cognitedata/python-extrac…
827452b 
…tor-utils into DOG-4448-file-extractor-simplify-extraction-failure-analysis
@nithinb nithinb merged commit e55df22 into master Jan 3, 2025
5 checks passed
@nithinb nithinb deleted the DOG-4448-file-extractor-simplify-extraction-failure-analysis branch January 3, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einarmo einarmo einarmo left review comments

@rsjr rsjr rsjr approved these changes

Assignees

@nithinb nithinb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nithinb @einarmo @rsjr